Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v0.38.3 #3157

Closed
wants to merge 3 commits into from
Closed

Release v0.38.3 #3157

wants to merge 3 commits into from
+30 −13

Conversation

MarcoPolo
Copy link
Collaborator

Includes [email protected]

Technically we are exporting a new type ErrCertHashMismatch, but the API is still returning the error interface so this should be okay.

@MarcoPolo MarcoPolo requested a review from sukunrt January 24, 2025 22:25
@github-actions GitHub Actions
Copy link

Suggested version: 0.38.3

Comparing to: v0.38.2 (diff)

Changes in configuration file(s):

(empty)

gorelease says:

gorelease: go: loading module retractions for honnef.co/go/[email protected]: module honnef.co/go/[email protected] requires go >= 1.22.1 (running go 1.22.0)

gocompat says:

HEAD is now at 6d93e738 Release v0.38.2 (#3147)
Switched to branch 'release-v038'
Your branch is up to date with 'origin/release-v038'.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to release-v038. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

sukunrt
sukunrt reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@sukunrt sukunrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this breaks Versioning

  1. Will upgrade quic-go for all clients.
  2. Exports new type from te webtransport transport.

Should we just make a new minor release?

go.mod
@@ -53,7 +53,7 @@ require (
github.com/pion/webrtc/v3 v3.3.5
github.com/prometheus/client_golang v1.20.5
github.com/prometheus/client_model v0.6.1
github.com/quic-go/quic-go v0.48.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this breaking semver?

p2p/transport/webtransport/crypto.go
Comment on lines +89 to +93
type ErrCertHashMismatch struct {
Expected []byte
Actual [][]byte
}

Copy link
Member

@sukunrt sukunrt Jan 25, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why introduce this in the patch release?

@MarcoPolo MarcoPolo closed this Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sukunrt sukunrt sukunrt left review comments

Assignees
No one assigned
Labels
release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarcoPolo @sukunrt